Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

add retries for systemctl commands #2639

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

jackfrancis
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

add retries for systemctl commands

@ghost ghost assigned jackfrancis Apr 9, 2018
@ghost ghost added the in progress label Apr 9, 2018
@@ -249,8 +249,8 @@ function installClearContainersRuntime() {

# Enable and start Clear Containers proxy service
echo "Enabling and starting Clear Containers proxy service..."
systemctl enable cc-proxy
systemctl start cc-proxy
systemctlEnableAndCheck cc-proxy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessfraz FYI

systemctl enable cc-proxy
systemctl start cc-proxy
systemctlEnableAndCheck cc-proxy
retrycmd_if_failure 100 1 10 systemctl daemon-reload && systemctl restart cc-proxy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -290,7 +290,7 @@ function ensureContainerd() {
# Make sure this is done after networking plugins are installed
echo "Enabling and starting cri-containerd service..."
systemctl enable containerd
systemctl start containerd
retrycmd_if_failure 100 1 10 systemctl daemon-reload && systemctl restart containerd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@jessfraz
Copy link
Contributor

jessfraz commented Apr 9, 2018

oh awesome thanks, sorry

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit d5df071 into Azure:master Apr 9, 2018
@jackfrancis jackfrancis deleted the systemctl-daemon-reload branch April 9, 2018 20:23
@ghost ghost removed the in progress label Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants